-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shellcheck issues #251
Fix shellcheck issues #251
Conversation
Hello @Bablzz ! Thank you for your contribution. As you can imagine it is very hard to enforce rules like this overtime if there is not a proper check in CI. We use Travis for that, and I won't merge this PR until we have a shellcheck in place for all the repo. Do you mind adding it to your pull request? |
Hi @gianarb |
You please, feel free to push a commit as part of this PR |
Amazing! Thanks a lot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this!! Thanks for the contribution 👏👏👏
Thanks a lot! |
Hello everyone!
I hope you are doing well
In this MR fixed small shellcheck.
Have a nice day