Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin vearch version #2568

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

It pins the version of the Vearch module, to avoid using latest.

Why is it important?

For some reason I noticed it during the review but did not commented about it. Changing it is important for reproducibility and not receive a wrong version of the module each time it's used.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner June 7, 2024 10:29
@mdelapenya mdelapenya added the dependencies Dependencies or external services label Jun 7, 2024
@mdelapenya mdelapenya self-assigned this Jun 7, 2024
Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 8b6de72
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6662e12937cc4600081bbd0c
😎 Deploy Preview https://deploy-preview-2568--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya merged commit e4f3811 into testcontainers:main Jun 7, 2024
106 checks passed
@mdelapenya
Copy link
Collaborator Author

@zhanghexian please take a look. I forgot to change this in your original PR.

Cheers!

@mdelapenya
Copy link
Collaborator Author

FTR I'm updating the modules catalog here: testcontainers/community-module-registry#51

mdelapenya added a commit that referenced this pull request Jun 7, 2024
* main:
  chore: pin vearch version (#2568)
mdelapenya added a commit to bearrito/testcontainers-go that referenced this pull request Jun 11, 2024
* main: (48 commits)
  Fix race condition when looking up reaper (ryuk) container (testcontainers#2508)
  chore: bring golangci-lint back (testcontainers#2571)
  docs(compose): Fix typo docker compose docs (testcontainers#2565)
  Handle error properly during port forwarding initialization. (testcontainers#2550)
  chore: pin vearch version (testcontainers#2568)
  feat: add vearch module (testcontainers#2560)
  chore: run tests against latest Docker engine, nightly (testcontainers#2566)
  chore(deps): bump mkdocs-include-markdown-plugin from 6.0.4 to 6.0.7 (testcontainers#2562)
  Fix network accessor for port-forwarding feature (testcontainers#2551)
  --- (testcontainers#2549)
  fix: update search bar eval in mkdocs (testcontainers#2547)
  docs: improve contributing docs for code snippets (testcontainers#2546)
  chore: use a virtualenv for working with the docs site (testcontainers#2545)
  docs: document test session semantics (testcontainers#2544)
  feat(ryuk): allow to configure ryuk timeouts using env variables (testcontainers#2541)
  docs: fix CircleCI docs (testcontainers#2539)
  fix: add import to module generation (testcontainers#2537)
  chore: prepare for next minor development cycle (0.32.0)
  chore: use new version (v0.31.0) in modules and examples
  feat(mongodb): add replica set support via opts (testcontainers#2469)
  ...
@mdelapenya mdelapenya deleted the vearch-version branch June 13, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies or external services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant