Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: move to github action #242 #257

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

Bablzz
Copy link
Contributor

@Bablzz Bablzz commented Oct 8, 2020

Hello everyone!

In this MR I add github action. There are the same steps as in .travis.yml

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bablzz, thank you for this great contribution. I added a few nits about names, but on the other hand it will LGTM after hearing your opinion.

Thanks! 👋

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Fix some issue after review
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

image

@mdelapenya
Copy link
Collaborator

@gianarb I think we can keep travis for a while, comparing executions, and once we are happy with GH, then move on removing Travis descriptor.

@gianarb gianarb merged commit f1da19a into testcontainers:master Oct 8, 2020
@gianarb
Copy link
Collaborator

gianarb commented Oct 8, 2020

THanks @Bablzz !!! and thanks @mdelapenya for your review!

@Bablzz
Copy link
Contributor Author

Bablzz commented Oct 8, 2020

@gianarb @mdelapenya My pleasure! 🤝

This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants