Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logging on image pull error #272

Conversation

tobiaszheller
Copy link
Contributor

Right now when something is wrong with pulling image, for example:

Error response from daemon: unauthorized: You don't have the needed permissions to perform this operation, and you may have invalid credentials. To authenticate your request, follow the steps in: https://cloud.google.com/container-registry/docs/advanced-authentication

there is no indication that any action is happening. This log will additional debug information if something is wrong.

@gianarb
Copy link
Collaborator

gianarb commented Dec 24, 2020

Thanks a lot! You have also added the retry! Good job!

@gianarb gianarb merged commit 5cce89b into testcontainers:master Dec 24, 2020
This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants