Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait strategies must poll ports #295

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Conversation

programminh
Copy link

@programminh programminh commented Mar 18, 2021

Docker engine 20.10.3 has changed the way ports are returned from InspectContainer. The array is not always populated which triggers a panic.

Related to #294

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #295 (4e4e126) into master (6467d9b) will decrease coverage by 1.09%.
The diff coverage is 23.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   64.04%   62.95%   -1.10%     
==========================================
  Files          13       13              
  Lines         865      880      +15     
==========================================
  Hits          554      554              
- Misses        226      242      +16     
+ Partials       85       84       -1     
Impacted Files Coverage Δ
wait/sql.go 0.00% <0.00%> (ø)
wait/http.go 56.04% <28.57%> (-1.43%) ⬇️
wait/host_port.go 56.14% <30.76%> (-4.28%) ⬇️
docker.go 65.20% <33.33%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6467d9b...4e4e126. Read the comment docs.

Copy link
Collaborator

@gianarb gianarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! good catch, I think caching without invalidation was for sure a poor choice I have made

@gianarb gianarb merged commit 54854fb into testcontainers:master Mar 31, 2021
@butuzov
Copy link

butuzov commented Apr 2, 2021

hi, @gianarb any plans on releasing this?
I needed to go full circle (from stepping on this issue in the new project to forking repo in order to fix it, only to find it's done by @programminh ). it's really desired fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants