close reaper go routines on DockerContainer.Terminate & DockerNetwork.Remove

[Eun]

This fixes the issue #319.

When Reaper is used, the DockerContainer.Terminate and DockerNetwork.Remove functions should close the spawned go routine by Reaper.Connect.

[mdelapenya]

Hi @Eun thanks for this PR, we'll review it ASAP. Would you mind adding the test you proposed in the original issue? Taht way we will be covered against regressions.

Thanks in advance

[Eun]

Hi @mdelapenya, adding a test would not be hegglpful since the other leak at #321 is still open, so adding a test as soon as both issues are fixed would make the most sense.
I guess just adding

func TestMain(m *testing.M) {
	goleak.VerifyTestMain(m)
}

would be enough.

[codecov]

Codecov Report

Merging #320 (906b5b4) into master (555d3e6) will increase coverage by 0.35%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
+ Coverage   63.18%   63.53%   +0.35%     
==========================================
  Files          13       13              
  Lines         910      916       +6     
==========================================
+ Hits          575      582       +7     
+ Misses        247      246       -1     
  Partials       88       88              

Impacted Files	Coverage Δ
docker.go	65.68% <83.33%> (+0.70%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555d3e6...906b5b4. Read the comment docs.

[gianarb]

Thanks a lot for taking the time and open this PR! I will have a look at the open issue around docker connections. I think we really need to add the test you proposed.