-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cache http wait request body #339
Conversation
See testcontainers#338 Closes testcontainers#338 Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajcasagrande thanks for taking your time to fix this, and the explanation on how to reproduce it.
I added a comment about the usage of a method that is failing in the test execution for Go 1.14.
Other than that, LGTM!
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Unit tests are failing due to #341. For now I have pinned the version of rabbitmq to |
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
==========================================
+ Coverage 60.91% 61.41% +0.50%
==========================================
Files 15 15
Lines 985 990 +5
==========================================
+ Hits 600 608 +8
+ Misses 293 290 -3
Partials 92 92
Continue to review full report at Codecov.
|
I also updated the test code to check for this specific issue. If you run the updated tests against the current
master
it will fail due to the bug that this addresses.Closes #338
Closes #341