#391: remember service map from all docker compose files #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
==========================================
- Coverage 63.35% 63.27% -0.09%
==========================================
Files 16 16
Lines 1067 1070 +3
==========================================
+ Hits 676 677 +1
- Misses 290 291 +1
- Partials 101 102 +1
Continue to review full report at Codecov.
|
mdelapenya
reviewed
Dec 15, 2021
Comment on lines
+201
to
+206
| if dc.Services == nil { | ||
| dc.Services = c.Services | ||
| } else { | ||
| for k, v := range c.Services { | ||
| dc.Services[k] = v | ||
| } |
mdelapenya
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #391
I added a new docker-compose file with postgres image. Hope thats okay.
Without this fix, services field keeps map for only the last docker-compose file passed. But there could be service that are not overridden in the last file, and it should keep those values in the map.