Remove custom built docker image on container termination #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My gofumpt made some linting fixes, let me know if I should reverse them. |
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
==========================================
+ Coverage 64.93% 65.20% +0.27%
==========================================
Files 19 19
Lines 1155 1164 +9
==========================================
+ Hits 750 759 +9
+ Misses 301 300 -1
- Partials 104 105 +1
Continue to review full report at Codecov.
|
mdelapenya
reviewed
Feb 28, 2022
| @@ -192,15 +193,26 @@ func (c *DockerContainer) Terminate(ctx context.Context) error { | |||
| RemoveVolumes: true, | |||
| Force: true, | |||
| }) | |||
| if err != nil { | |||
| return err | |||
There was a problem hiding this comment.
Cool! It seems we missed to handle this error
mdelapenya
approved these changes
Feb 28, 2022
|
Hey @gaborszakacs thanks for this contribution. The ability you contributed was under our radar but had no time to implement it, so thank you very much for your contribution. Looks great! |
mdelapenya
added
the
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #303