expose CopyToContainer so file can be created only in memory #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is especially useful in tests, since we do not need to create a file for testing, we can just generate it in memory and then copy it to a container directly
mdelapenya
reviewed
Mar 22, 2022
| @@ -395,7 +395,11 @@ func (c *DockerContainer) CopyFileToContainer(ctx context.Context, hostFilePath | |||
| if err != nil { | |||
| return err | |||
| } | |||
| return c.CopyToContainer(ctx, fileContent, containerFilePath, fileMode) | |||
mdelapenya
added
the
feature
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
==========================================
- Coverage 65.38% 65.24% -0.15%
==========================================
Files 19 19
Lines 1170 1171 +1
==========================================
- Hits 765 764 -1
- Misses 300 301 +1
- Partials 105 106 +1
Continue to review full report at Codecov.
|
mdelapenya
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is especially useful in tests, since we do not
need to create a file for testing,
we can just generate it in memory and then
copy it to a container directly