Update go-redis to v8.11.5 #424
Conversation
Codecov Report
@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 70.16% 69.67% -0.49%
==========================================
Files 21 21
Lines 2048 2048
==========================================
- Hits 1437 1427 -10
- Misses 490 497 +7
- Partials 121 124 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Looked at the failing test but I'm not sure it's related to this PR? |
|
This should be ready for a re-review now. Thanks! |
|
HI @johanoskarsson I did not review it on purpose as we have to internally discuss about modules, and because we are adding a dependency on redis to downstream users, I'd like to maybe move that dependency (and its tests) to an eventual Redis module. Of course, because this change is totally harmless, it can make it to the next release (hopefully super soon) |
| @@ -1024,7 +1024,7 @@ func Test_BuildContainerFromDockerfile(t *testing.T) { | |||
| }) | |||
|
|
|||
| t.Log("pinging redis") | |||
| pong, err := client.Ping().Result() | |||
| pong, err := client.Ping(ctx).Result() | |||
There was a problem hiding this comment.
Mmm it's weird the the docs are updated since 25fc53e
Brings the go-redis package up to the latest version.
Ran the test that uses redis:
Test_BuildContainerFromDockerfilelocally and it passes.Side note: when I try to run all the tests in the repo on main I get failures. Not sure if that has to do with my local setup or if main is broken?