Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temp fix of flaky test #455

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Conversation

funvit
Copy link
Contributor

@funvit funvit commented Jun 13, 2022

Closes #411

Simple retry with time limit added into test.

Maybe move retry into Endpoint function? Or it will be a breaking change?

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let's merge it and observe it alongside other PRs. We can reopen #411 if needed

@mdelapenya mdelapenya merged commit 28706cb into testcontainers:main Jun 13, 2022
@mdelapenya mdelapenya added the test flakiness Report a flaky test that happens on the CI label Jun 27, 2022
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality test flakiness Report a flaky test that happens on the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: TestContainerLogWithErrClosed
2 participants