Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that environment is clean #458

Conversation

VladimirStepanov
Copy link
Contributor

close #158

@VladimirStepanov
Copy link
Contributor Author

@mdelapenya Hi! Could you check this solution?

@mdelapenya
Copy link
Collaborator

mdelapenya commented Jun 14, 2022

@mdelapenya Hi! Could you check this solution?

I think this would work 👍

On the other hand, I'm missing a contributing guide in the project, not in this PR of course. I'd add the usage of this shell script (and the one for linting) once we create that guide in order it's possible to run those scripts locally for checking state.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #458 (6a1ad0a) into main (28706cb) will increase coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   65.55%   65.94%   +0.39%     
==========================================
  Files          19       19              
  Lines        1199     1201       +2     
==========================================
+ Hits          786      792       +6     
+ Misses        305      303       -2     
+ Partials      108      106       -2     
Impacted Files Coverage Δ
container.go 87.23% <0.00%> (ø)
docker.go 66.54% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28706cb...6a1ad0a. Read the comment docs.

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this small but important contribution!

scripts/check_environment.sh Show resolved Hide resolved
@mdelapenya
Copy link
Collaborator

In https://github.com/testcontainers/testcontainers-go/runs/6905008920?check_suite_focus=true we see there is a container not stopped:
Screenshot 2022-06-16 at 07 33 59

Could you try to identify it and stopped in the test suite?

@VladimirStepanov
Copy link
Contributor Author

@mdelapenya Fixed:)
Now we pass all tests successfully

@VladimirStepanov
Copy link
Contributor Author

@mdelapenya Could we merge it?

@mdelapenya mdelapenya merged commit e4975ad into testcontainers:main Jun 20, 2022
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add final check in CI to double check that environment is clean
2 participants