-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check that environment is clean #458
check that environment is clean #458
Conversation
@mdelapenya Hi! Could you check this solution? |
I think this would work 👍 On the other hand, I'm missing a contributing guide in the project, not in this PR of course. I'd add the usage of this shell script (and the one for linting) once we create that guide in order it's possible to run those scripts locally for checking state. |
Codecov Report
@@ Coverage Diff @@
## main #458 +/- ##
==========================================
+ Coverage 65.55% 65.94% +0.39%
==========================================
Files 19 19
Lines 1199 1201 +2
==========================================
+ Hits 786 792 +6
+ Misses 305 303 -2
+ Partials 108 106 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this small but important contribution!
In https://github.com/testcontainers/testcontainers-go/runs/6905008920?check_suite_focus=true we see there is a container not stopped: Could you try to identify it and stopped in the test suite? |
@mdelapenya Fixed:) |
@mdelapenya Could we merge it? |
close #158