-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 225 copy files before container started #460
Issue 225 copy files before container started #460
Conversation
@mdelapenya could you check this solution?) productive day :)) |
@mdelapenya hi! excuse for troubling :) |
Could you resolve conflicts? I think this is good to merge right after that 🚀 |
Codecov Report
@@ Coverage Diff @@
## main #460 +/- ##
==========================================
+ Coverage 69.56% 69.97% +0.41%
==========================================
Files 21 21
Lines 1942 1952 +10
==========================================
+ Hits 1351 1366 +15
+ Misses 474 470 -4
+ Partials 117 116 -1
Continue to review full report at Codecov.
|
@mdelapenya Resolved:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left minor comments regarding the docs.
BTW, could you add the copy_file.md entry to the mkdocs.yml
file? I noticed it's missing! Please add it above the docker-compose one.
Thanks in advance for your work here
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
@mdelapenya Thank you for your comments! Fixed |
Close #225
Copy files before the container is created