Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 225 copy files before container started #460

Conversation

VladimirStepanov
Copy link
Contributor

Close #225

Copy files before the container is created

container.go Outdated Show resolved Hide resolved
@VladimirStepanov VladimirStepanov changed the title Issue 225 copy files before container started new Issue 225 copy files before container started Jun 14, 2022
@VladimirStepanov
Copy link
Contributor Author

@mdelapenya could you check this solution?) productive day :))

container.go Outdated Show resolved Hide resolved
@VladimirStepanov
Copy link
Contributor Author

@mdelapenya hi! excuse for troubling :)
could you check this PR, plz?)

docker_test.go Outdated Show resolved Hide resolved
@mdelapenya
Copy link
Collaborator

Could you resolve conflicts? I think this is good to merge right after that 🚀

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #460 (43d7224) into main (f93cdb4) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   69.56%   69.97%   +0.41%     
==========================================
  Files          21       21              
  Lines        1942     1952      +10     
==========================================
+ Hits         1351     1366      +15     
+ Misses        474      470       -4     
+ Partials      117      116       -1     
Impacted Files Coverage Δ
container.go 80.72% <ø> (ø)
docker.go 70.95% <100.00%> (+0.91%) ⬆️
reaper.go 83.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93cdb4...43d7224. Read the comment docs.

@VladimirStepanov
Copy link
Contributor Author

@mdelapenya Resolved:)

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left minor comments regarding the docs.

BTW, could you add the copy_file.md entry to the mkdocs.yml file? I noticed it's missing! Please add it above the docker-compose one.

Thanks in advance for your work here

VladimirStepanov and others added 2 commits July 5, 2022 17:46
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
VladimirStepanov and others added 2 commits July 5, 2022 17:47
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
@VladimirStepanov
Copy link
Contributor Author

@mdelapenya Thank you for your comments! Fixed

@mdelapenya mdelapenya merged commit 686e4ea into testcontainers:main Jul 5, 2022
@mdelapenya mdelapenya added the feature New functionality or new behaviors on the existing one label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Copy files into created container
3 participants