Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update podman pipeline #478

Merged
merged 8 commits into from
Jul 5, 2022

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

It updates the pipeline for Podman with the recent changes about using a Makefile for running the tests, and a shell script checking there is no containers at the end of the test execution.

Besides, it's adding go mod commands to standardize the mod file for each Go version that is supported

Why is it important?

Using Make creates a consistent manner of running the tests

The go mod commands should fix the Podman pipeline

@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Jul 5, 2022
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #478 (804fbc0) into main (82aae91) will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   69.64%   69.38%   -0.26%     
==========================================
  Files          21       21              
  Lines        1947     1947              
==========================================
- Hits         1356     1351       -5     
- Misses        474      477       +3     
- Partials      117      119       +2     
Impacted Files Coverage Δ
docker.go 69.63% <0.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82aae91...804fbc0. Read the comment docs.

@mdelapenya mdelapenya self-assigned this Jul 5, 2022
@mdelapenya mdelapenya merged commit b5ff9a2 into testcontainers:main Jul 5, 2022
@mdelapenya mdelapenya added the podman Issues regarding podman. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality podman Issues regarding podman.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant