refactor: more nuanced env vs properties config #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #479 +/- ##
==========================================
+ Coverage 69.79% 69.94% +0.14%
==========================================
Files 21 21
Lines 1947 1950 +3
==========================================
+ Hits 1359 1364 +5
+ Misses 472 470 -2
Partials 116 116
Continue to review full report at Codecov.
|
mdelapenya
reviewed
Jul 5, 2022
The environment variables should trump configuration from `$HOME/.testcontainers.properties` file, but only if they're set and then only if they equal `true` or `false`. This refactors `configureTC` to make sure that environment variables are always considered and indeed trump any configuration in `$HOME/.testcontainers.properties` file, even as parsing the configuration from `$HOME/.testcontainers.properties` completes partially. Also the `HOME is not set` test cases now do not set the `$HOME` so that the `os.UserHomeDir` error path is exercised by the tests.
zregvart
force-pushed
the
pr/nuanced-config
branch
from
50462dd
to
e2ec1af
Compare
mdelapenya
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variables should trump configuration from
$HOME/.testcontainers.propertiesfile, but only if they're set and then only if they equaltrueorfalse. This refactorsconfigureTCto make sure that environment variables are always considered and indeed trump any configuration in$HOME/.testcontainers.propertiesfile, even as parsing the configuration from$HOME/.testcontainers.propertiescompletes partially. Also theHOME is not settest cases now do not set the$HOMEso that theos.UserHomeDirerror path is exercised by the tests.