Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auth config for build images #602

Conversation

paulozenida
Copy link
Contributor

This PR allows for the feature reported in the following issue: #601

@paulozenida paulozenida requested a review from a team as a code owner October 31, 2022 13:34
container_test.go Show resolved Hide resolved
docker_test.go Outdated Show resolved Hide resolved
docker_test.go Show resolved Hide resolved
@mdelapenya
Copy link
Collaborator

mdelapenya commented Nov 3, 2022

@paulozenida I saw the PR is failing the TestDockerCreateContainerWithDirs test because here

srcBytes, err := ioutil.ReadFile(filepath.Join(hostFilePath, srcFile.Name()))
the existing code is not controlling that a directory could exist under testresources. At the moment you added the registry dirs, that test fails, and I think it should be fixed in this PR.

I'd say that simply checking the current srcFile is not a directory, and then read it would be enough. Could you include it in this PR?

Thanks!

@paulozenida
Copy link
Contributor Author

Sure. I've just included the suggested change.

@mdelapenya mdelapenya added the enhancement New feature or request label Nov 3, 2022
@mdelapenya mdelapenya self-assigned this Nov 3, 2022
@mdelapenya
Copy link
Collaborator

Sure. I've just included the suggested change.

To avoid causing you more trouble in the pingpong review on failed tests, I added a commit with the same fix in another test: TestTarDir. Hopefully this will PASS 🤞

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @paulozenida in this PR!

I'm updating the branch with current main. Once the CI passes, I'll merge it 🚀

BTW; the project is missing the same mechanism for pulling images from private registries in other places. As you already contributed this part for the FromDockerfile part, I wonder if you would be interested in contributing the others, such as the Docker Compose code. I can be of any help assisting you identifying where to add it. Please let me know if you'd like to participate.

@mdelapenya mdelapenya merged commit cc9c80d into testcontainers:main Nov 3, 2022
14 checks passed
@paulozenida paulozenida deleted the feature/auth-config-for-build-images branch November 3, 2022 13:46
@paulozenida
Copy link
Contributor Author

Great job @paulozenida in this PR!

I'm updating the branch with current main. Once the CI passes, I'll merge it 🚀

BTW; the project is missing the same mechanism for pulling images from private registries in other places. As you already contributed this part for the FromDockerfile part, I wonder if you would be interested in contributing the others, such as the Docker Compose code. I can be of any help assisting you identifying where to add it. Please let me know if you'd like to participate.

Thank @mdelapenya.

I'm not sure I'll be able to do that right now but if you open an issue explaining the details, I might try to get to it next week or try to find someone in my organisation/team that can try to do so.

mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Nov 9, 2022
* main:
  docs: networking basics (testcontainers#612)
  docs: wording in project name (testcontainers#610)
  feat: Auth config for build images (testcontainers#602)
  chore: sync governance files (testcontainers#608)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants