Reaper container should not be labeled with "org.testcontainers.golang.sessionId" #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….sessionId. Fixes #698.
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
HofmeisterAn
approved these changes
Jan 5, 2023
|
Is there anything I can do to have it merged? |
|
Manu is expected to be back next week. I am certain we will address it until the end of next week. |
mdelapenya
changed the title
|
I think it's fine to remove the sessionId label from the Ryuk container request. Relates to testcontainers/moby-ryuk#53 |
mdelapenya
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
….sessionId. Fixes #698.
Sorry something strange happened to previous PR