Add devcontainer file #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devcontainer is the definition file used by GitHub Codespaces.
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mdelapenya
reviewed
Jan 18, 2023
HofmeisterAn
previously approved these changes
Jan 18, 2023
mdelapenya
reviewed
Jan 24, 2023
.devcontainer/devcontainer.json
Outdated
Comment on lines
33
to
40
| // Use 'forwardPorts' to make a list of ports inside the container available locally. | ||
| // "forwardPorts": [], | ||
|
|
||
| // Use 'postCreateCommand' to run commands after the container is created. | ||
| // "postCreateCommand": "go version", | ||
|
|
||
| // Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root. | ||
| // "remoteUser": "root" |
There was a problem hiding this comment.
Should we remove all these comments? Or at least, let's define what postCreateCommand to use.
I can see we compile the project in Java: https://github.com/testcontainers/testcontainers-java/blob/dbb9be00b91f582e8fdc76e569b700c9f8fb88d0/.devcontainer/devcontainer.json#L48 and in .NET https://github.com/testcontainers/testcontainers-dotnet/blob/eb4a6d9aa267673487aa66b9951edee40c3e9006/.devcontainer/devcontainer.json#L29-L30
We can probably run go build
There was a problem hiding this comment.
I like both suggestions 👍
There was a problem hiding this comment.
Yes, let's do like this. Nowadays the format is kind of established after all.
eddumelendez
dismissed stale reviews from HofmeisterAn and mdelapenya
via
b3d3cce
mdelapenya
previously approved these changes
Jan 24, 2023
mdelapenya
reviewed
Jan 24, 2023
kiview
previously approved these changes
Jan 26, 2023
.devcontainer/devcontainer.json
Outdated
Comment on lines
33
to
40
| // Use 'forwardPorts' to make a list of ports inside the container available locally. | ||
| // "forwardPorts": [], | ||
|
|
||
| // Use 'postCreateCommand' to run commands after the container is created. | ||
| // "postCreateCommand": "go version", | ||
|
|
||
| // Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root. | ||
| // "remoteUser": "root" |
There was a problem hiding this comment.
Yes, let's do like this. Nowadays the format is kind of established after all.
|
Merging as the changes are not affecting the build, thanks! |
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Feb 10, 2023
* main: chore: update Docker labels for containers (testcontainers#813) fix: nil pointer dereference in HealthStrategy (testcontainers#802) fix: Synchronise writes to containers map (testcontainers#812) chore(deps): bump google.golang.org/api from 0.108.0 to 0.109.0 in /examples (testcontainers#810) chore(deps): bump cloud.google.com/go/spanner in /examples/spanner (testcontainers#806) chore: restructure Docker helper methods (testcontainers#799) Verify Reaper state to create new or return existing instance (testcontainers#782) docs: add intel as user (testcontainers#798) chore: bump containerd in examples (testcontainers#797) chore(deps): bump github.com/containerd/containerd from 1.6.15 to 1.6.16 (testcontainers#793) chore: extract docker host calculation to an internal package (testcontainers#796) chore: run "go mod tidy" automatically when creating examples (testcontainers#794) chore: build images with backoff retries (testcontainers#792) fix: use right import package for compose in docs (testcontainers#791) chore(deps): bump google.golang.org/grpc from 1.52.1 to 1.52.3 in /examples (testcontainers#790) Add devcontainer file (testcontainers#765) chore: check dependabot dependencies weekly (testcontainers#789) chore(deps): bump google.golang.org/grpc from 1.52.0 to 1.52.1 in /examples (testcontainers#783) chore: support for titles in examples (testcontainers#775)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devcontainer is the definition file used by GitHub Codespaces.