Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove replace directive in modules #871

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

It removes an outdated replace directive for Docker deps in the example modules, running go mod tidy in them

Why is it important?

Keep depedencies up-to-date.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner February 22, 2023 12:50
@mdelapenya mdelapenya added chore Changes that do not impact the existing functionality dependencies Dependencies or external services labels Feb 22, 2023
@mdelapenya mdelapenya self-assigned this Feb 22, 2023
@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 6157758
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/63f60fad5231a20008e7dd8b
😎 Deploy Preview https://deploy-preview-871--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mdelapenya mdelapenya merged commit ddc8e21 into testcontainers:main Feb 22, 2023
@mdelapenya mdelapenya deleted the fix-modules-imports branch February 22, 2023 14:03
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Feb 23, 2023
* main:
  chore(deps): bump github.com/compose-spec/compose-go from 1.9.0 to 1.11.0 in /modules/compose (testcontainers#865)
  chore(deps): bump github.com/docker deps from 23.0.0+incompatible to 23.0.1+incompatible (testcontainers#875)
  chore(deps): bump github.com/aws/aws-sdk-go libs in /modules/localstack (testcontainers#874)
  chore: simplify env vars for localstack module (testcontainers#873)
  chore: remove replace directive in modules (testcontainers#871)
  chore: bump testcontainers-go in Go modules (testcontainers#870)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality dependencies Dependencies or external services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant