feat: add Vault Module #942
Conversation
…ervicesEnabled with gjson
…ure external port
# Conflicts: # wait/http.go
# Conflicts: # .github/dependabot.yml
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Thanks for your contribution @alihanyalcin ! I have left some comments based on the experience in Java modules implementation in general. I understand the implementation has been based on Testcontainers for Java but let's build a better version of it in Go 😉
There was a problem hiding this comment.
@alihanyalcin another great PR for the vault module, thank you for your love to Testcontainers!
I'll wait for @eddumelendez to check the comments he had before merging the PR, but other than that, great job!
|
Hi @mdelapenya @eddumelendez I've added requested changes. |
|
I'm waiting for the CI to add this new module. Thanks @alihanyalcin for your dedication here making Testcontainers for Go greater! |
|
Kudos, SonarCloud Quality Gate passed!
|
What does this PR do?
Support for Vault containers
Why is it important?
Vault is an open-source tool designed for securely storing, accessing, and managing secrets and sensitive data such as passwords, certificates, API keys, and other confidential information.