-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add status check to wait strategies #944
feat: add status check to wait strategies #944
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frozenbonito it LGTM, thanks for your contribution!
I added a few comments, minors, but wanted to check with you first before approving the PR.
4900223
to
6c456ee
Compare
6c456ee
to
1584e32
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your patience during the review
We really appreciate your love for OSS and Testcontainers for Go!
What does this PR do?
This PR adds container status check to wait strategies while polling.
Why is it important?
Some strategies assume the container is running.
However, a container may terminate due to an unexpected error, etc. Even in this case, testcontainers-go will keep waiting until the timeout.
This PR enables fail-fast when a container stops.
Related issues