Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: extend Couchbase docs #971

Merged
merged 7 commits into from
Mar 23, 2023

Conversation

mdelapenya
Copy link
Collaborator

@mdelapenya mdelapenya commented Mar 23, 2023

What does this PR do?

It adds a module reference section in the docs, describing each exposed function in the public API, including code snippets extracted from the code.

At the same time, we are adding Go docs for the public API.

Finally, we are moving the test methods to a test package, so that we demonstrate the real usage of the module from inside.

Render URL: https://deploy-preview-971--testcontainers-go.netlify.app/modules/couchbase

Why is it important?

Make the module more usable through docs

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner March 23, 2023 10:32
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Mar 23, 2023
@mdelapenya mdelapenya self-assigned this Mar 23, 2023
@netlify
Copy link

netlify bot commented Mar 23, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 8115753
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/641c3e260306c60008bd5ee7
😎 Deploy Preview https://deploy-preview-971--testcontainers-go.netlify.app/modules/couchbase
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mdelapenya
Copy link
Collaborator Author

@alihanyalcin could you please take a look? I'm extending the docs for the recently added Couchbase module.

Thanks in advance!

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alihanyalcin
Copy link
Contributor

Hi @mdelapenya, LGTM! 🚀

@mdelapenya mdelapenya merged commit 2de5486 into testcontainers:main Mar 23, 2023
@mdelapenya mdelapenya deleted the couchbase-docs branch March 23, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants