alex/reaper #33
Merged
alex/reaper #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbiehl
force-pushed
the
alex/reaper
branch
from
ab8dcc8
to
8065a72
Compare
alexbiehl
force-pushed
the
alex/reaper
branch
from
8065a72
to
6fb7849
Compare
fabioluz
approved these changes
Feb 4, 2023
fabioluz
approved these changes
Feb 5, 2023
alexbiehl
commented
Feb 5, 2023
alexbiehl
force-pushed
the
alex/reaper
branch
from
86e21c9
to
39119cf
Compare
alexbiehl
force-pushed
the
alex/reaper
branch
from
39119cf
to
f238115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces proper resource cleanup using the ryuk container. We attach a label containing a session id to each network and container and once done, ryuk cleans up all the resources. This allows us to worry less about container and network lifecycles.
This approach is also taken by the official testcontainers java library.