Skip to content

Commit

Permalink
Convert Docs for Webdriver Containers
Browse files Browse the repository at this point in the history
Convert inline example code to use codeinclude macro for the Webdriver Containers documentation.
See #1158 for more details.

Fixed ChromeRecordingWebDriverContainerTest which was crashed by previous commit.
Fix Labels for RECORD_ALL, RECORD_FAILING enum values.
  • Loading branch information
raynigon committed Jun 23, 2020
1 parent 62a6be8 commit 0842999
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/modules/webdriver_containers.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ By default, no videos will be recorded. However, you can instruct Testcontainers
just for failing tests.

<!--codeinclude-->
[RECORD_ALL](../../modules/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java) inside_block:recordAll
[RECORD_FAILING](../../modules/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java) inside_block:recordFailing
[Record all Tests](../../modules/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java) inside_block:recordAll
[Record failing Tests](../../modules/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java) inside_block:recordFailing
<!--/codeinclude-->

Note that the seconds parameter to `withRecordingMode` should be a directory where recordings can be saved.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ public void recordingTestThatShouldBeRecordedButNotPersisted() {
.withRecordingFileFactory(new CustomRecordingFileFactory())
// }
) {
chrome.start();

doSimpleExplore(chrome);
}
}
Expand Down

0 comments on commit 0842999

Please sign in to comment.