Skip to content

Commit

Permalink
Upgrade Ryuk to 0.3.1 (#3629)
Browse files Browse the repository at this point in the history
Co-authored-by: Sergei Egorov <bsideup@gmail.com>
  • Loading branch information
rnorth and bsideup committed Dec 29, 2020
1 parent 30f399e commit 184afdd
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public static String start(String hostIpAddress, DockerClient client) {
@SneakyThrows(InterruptedException.class)
public static String start(DockerClient client) {
String ryukImage = ImageNameSubstitutor.instance()
.apply(DockerImageName.parse("testcontainers/ryuk:0.3.0"))
.apply(DockerImageName.parse("testcontainers/ryuk:0.3.1"))
.asCanonicalNameString();
DockerClientFactory.instance().checkAndPullImage(client, ryukImage);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ public void shouldReadReuseFromEnvironment() {

@Test
public void shouldTrimImageNames() {
userProperties.setProperty("ryuk.container.image", " testcontainersofficial/ryuk:0.3.0 ");
assertEquals("trailing whitespace was not removed from image name property", "testcontainersofficial/ryuk:0.3.0",newConfig().getRyukImage());
userProperties.setProperty("ryuk.container.image", " testcontainers/ryuk:0.3.1 ");
assertEquals("trailing whitespace was not removed from image name property", "testcontainers/ryuk:0.3.1",newConfig().getRyukImage());
}

private TestcontainersConfiguration newConfig() {
Expand Down
4 changes: 2 additions & 2 deletions docs/features/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ It takes a couple of seconds, but if you want to speed up your tests, you can di
Testcontainers uses public Docker images to perform different actions like startup checks, VNC recording and others.
Some companies disallow the usage of Docker Hub, but you can override `*.image` properties with your own images from your private registry to workaround that.

> **ryuk.container.image = testcontainers/ryuk:0.3.0**
> **ryuk.container.image = testcontainers/ryuk:0.3.1**
> Performs fail-safe cleanup of containers, and always required (unless [Ryuk is disabled](#disabling-ryuk))
> **tinyimage.container.image = alpine:3.5**
Expand All @@ -74,7 +74,7 @@ Some companies disallow the usage of Docker Hub, but you can override `*.image`
## Customizing Ryuk resource reaper

> **ryuk.container.image = testcontainers/ryuk:0.3.0**
> **ryuk.container.image = testcontainers/ryuk:0.3.1**
> The resource reaper is responsible for container removal and automatic cleanup of dead containers at JVM shutdown
> **ryuk.container.privileged = false**
Expand Down

0 comments on commit 184afdd

Please sign in to comment.