Fixed HostPortWaitStrategy throws NumberFormatException when port…

… is exposed but not mapped (#640) * Fixed `HostPortWaitStrategy` throws `NumberFormatException` when port is exposed but not mapped * updated exposed port tests are suggested in code review
testcontainers · Apr 11, 2018 · b5181f7 · b5181f7
1 parent fd1a079
commit b5181f7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file.
 ## UNRELEASED
 
 ### Fixed
+- Fixed `HostPortWaitStrategy` throws `NumberFormatException` when port is exposed but not mapped [\#640](https://github.com/testcontainers/testcontainers-java/issues/640))
 
 ### Changed
 

diff --git a/core/src/main/java/org/testcontainers/containers/ContainerState.java b/core/src/main/java/org/testcontainers/containers/ContainerState.java
@@ -11,6 +11,7 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.stream.Collectors;
 
 public interface ContainerState {
@@ -127,6 +128,7 @@ default List<Integer> getBoundPortNumbers() {
             .map(PortBinding::parse)
             .map(PortBinding::getBinding)
             .map(Ports.Binding::getHostPortSpec)
+            .filter(Objects::nonNull)
             .map(Integer::valueOf)
             .collect(Collectors.toList());
     }

diff --git a/core/src/test/resources/v2-compose-test.yml b/core/src/test/resources/v2-compose-test.yml
@@ -1,4 +1,6 @@
 version: '2'
 services:
   redis:
-    image: redis
+    image: redis
+    ports:
+      - 6379