Selenium: Restore getDockerImageForCapabilities method to public scope (

#3441)
testcontainers · Nov 8, 2020 · e2c55a2 · e2c55a2
1 parent d57a2bb
commit e2c55a2
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java b/modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java
@@ -189,7 +189,7 @@ protected void configure() {
             customImageName.assertCompatibleWith(COMPATIBLE_IMAGES);
             super.setDockerImageName(customImageName.asCanonicalNameString());
         } else {
-            DockerImageName standardImageForCapabilities = getImageForCapabilities(capabilities, seleniumVersion);
+            DockerImageName standardImageForCapabilities = getStandardImageForCapabilities(capabilities, seleniumVersion);
             super.setDockerImageName(standardImageForCapabilities.asCanonicalNameString());
         }
 
@@ -218,7 +218,22 @@ protected void configure() {
         setStartupAttempts(3);
     }
 
-    private static DockerImageName getImageForCapabilities(Capabilities capabilities, String seleniumVersion) {
+    /**
+     * @param capabilities a {@link Capabilities} object for either Chrome or Firefox
+     * @param seleniumVersion the version of selenium in use
+     * @return an image name for the default standalone Docker image for the appropriate browser
+     *
+     * @deprecated note that this method is deprecated and may be removed in the future. The no-args
+     * {@link BrowserWebDriverContainer#BrowserWebDriverContainer()} combined with the
+     * {@link BrowserWebDriverContainer#withCapabilities(Capabilities)} method should be considered. A decision on
+     * removal of this deprecated method will be taken at a future date.
+     */
+    @Deprecated
+    public static String getDockerImageForCapabilities(Capabilities capabilities, String seleniumVersion) {
+        return getStandardImageForCapabilities(capabilities, seleniumVersion).asCanonicalNameString();
+    }
+
+    private static DockerImageName getStandardImageForCapabilities(Capabilities capabilities, String seleniumVersion) {
         String browserName = capabilities.getBrowserName();
         switch (browserName) {
             case BrowserType.CHROME: