Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy for adding new modules #1503

Closed
rnorth opened this issue May 28, 2019 · 2 comments
Closed

Policy for adding new modules #1503

rnorth opened this issue May 28, 2019 · 2 comments

Comments

@rnorth
Copy link
Member

rnorth commented May 28, 2019

We often receive proposals (or fully formed PRs) for new modules, but don't have a clear policy on whether to accept them or not.

In the past we have accepted a small number of modules that have caused us significant maintenance headaches long after the contributor has gone away, and I'd like to avoid this in future. Equally, we'd like to encourage useful modules to be contributed!

We should have a policy in our documentation that:

  • Describes our criteria for 'what kinds of module we would accept', so that people can work out whether to expend effort on a contribution.

  • Provides a checklist for things we look for in a module PR (e.g. mainstream appeal, reliability and licensing for required docker images, docs, etc)

  • Sets out a process for gently onboarding a new module into the official modules 'ecosystem' - e.g. ensuring stability of tests in our CI, scope for user feedback that may change the public API, etc. My initial thought is some kind of beta/incubator label for new modules.

@stale
Copy link

stale bot commented Aug 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Aug 26, 2019
@rnorth rnorth removed the stale label Aug 27, 2019
@rnorth
Copy link
Member Author

rnorth commented Aug 27, 2019

This was actually resolved in #1576

@rnorth rnorth closed this as completed Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant