Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ceph support #497

Closed
wants to merge 9 commits into from
Closed

Add ceph support #497

wants to merge 9 commits into from

Conversation

tolkonepiu
Copy link
Contributor

Add support for Ceph

Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I requested some changes, but in general, it looks good :)

@rnorth
Copy link
Member

rnorth commented Feb 11, 2018

We're shortly going to be merging #574, which changes our build system to Gradle. This is in part intended to make contributions of modules easier (per #564), but unfortunately means that for a short while your PR is going to show merge conflicts with the master branch.

I just want to let you know we don't want to create new work for you: we'll take care of the merge conflicts shortly. Please don't worry - we're grateful for your PR and want to help integrate it soon. Thank you.

@tolkonepiu
Copy link
Contributor Author

@rnorth done

@stale
Copy link

stale bot commented Jan 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Jan 7, 2019
@rnorth
Copy link
Member

rnorth commented Jan 8, 2019

We should keep this open.

Sent with GitHawk

@kiview
Copy link
Member

kiview commented Jan 8, 2019

@rnorth Something missing for you? Seems good to merge.

@stale stale bot removed the stale label Jan 8, 2019
@bsideup
Copy link
Member

bsideup commented Jan 8, 2019

@kiview we should remove at least the self typing here

modules/ceph/build.gradle Outdated Show resolved Hide resolved
@tolkonepiu
Copy link
Contributor Author

@bsideup ping

@rnorth
Copy link
Member

rnorth commented May 28, 2019

FWIW I've raised this ticket around the current gap in our docs for new module contributors. I'd like to have a bit of a think about the third point specifically before merging this, but otherwise I'm fine with this new module at an overall level: #1503

@stale
Copy link

stale bot commented Aug 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Aug 26, 2019
@rnorth
Copy link
Member

rnorth commented Aug 26, 2019

Not stale - reopening.

@stale stale bot removed the stale label Aug 26, 2019
@stale
Copy link

stale bot commented Nov 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Nov 24, 2019
@stale stale bot removed the stale label Nov 25, 2019
@stale
Copy link

stale bot commented Feb 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Feb 27, 2020
@rnorth rnorth removed the stale label Mar 5, 2020
@rnorth rnorth mentioned this pull request May 8, 2020
@rnorth
Copy link
Member

rnorth commented May 8, 2020

I've made some tweaks but cannot push to the original branch, so have raised #2687. Will close this original PR.

@rnorth rnorth closed this May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants