-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ceph support #497
Add ceph support #497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I requested some changes, but in general, it looks good :)
modules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java
Outdated
Show resolved
Hide resolved
modules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java
Outdated
Show resolved
Hide resolved
modules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java
Outdated
Show resolved
Hide resolved
modules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java
Outdated
Show resolved
Hide resolved
modules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java
Outdated
Show resolved
Hide resolved
modules/ceph/src/test/java/org/testcontainers/containers/CephContainerTest.java
Show resolved
Hide resolved
We're shortly going to be merging #574, which changes our build system to Gradle. This is in part intended to make contributions of modules easier (per #564), but unfortunately means that for a short while your PR is going to show merge conflicts with the master branch. I just want to let you know we don't want to create new work for you: we'll take care of the merge conflicts shortly. Please don't worry - we're grateful for your PR and want to help integrate it soon. Thank you. |
@rnorth done |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
We should keep this open. Sent with GitHawk |
@rnorth Something missing for you? Seems good to merge. |
@kiview we should remove at least the self typing here |
modules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java
Outdated
Show resolved
Hide resolved
modules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java
Outdated
Show resolved
Hide resolved
modules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java
Outdated
Show resolved
Hide resolved
modules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java
Outdated
Show resolved
Hide resolved
modules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java
Outdated
Show resolved
Hide resolved
modules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java
Outdated
Show resolved
Hide resolved
modules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java
Outdated
Show resolved
Hide resolved
@bsideup ping |
FWIW I've raised this ticket around the current gap in our docs for new module contributors. I'd like to have a bit of a think about the third point specifically before merging this, but otherwise I'm fine with this new module at an overall level: #1503 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
Not stale - reopening. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
I've made some tweaks but cannot push to the original branch, so have raised #2687. Will close this original PR. |
Add support for Ceph