Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent GenericContainerRuleTest::sharedMemorySetTest test failures in CI #1688

Closed
rnorth opened this issue Jul 30, 2019 · 2 comments
Closed

Comments

@rnorth
Copy link
Member

rnorth commented Jul 30, 2019

See Azure CI reports for a summary: dev.azure.com/testcontainers/testcontainers-java/_test/analytics?definitionId=5&contextType=build - this test has a ~75% pass rate.

Apparent on Azure CI and Travis CI.

We should investigate why this is a flaky test and resolve.

Error message:

Gradle Test Executor 2 > org.testcontainers.junit.GenericContainerRuleTest > sharedMemorySetTest FAILED
    org.testcontainers.containers.ContainerLaunchException: Container startup failed
        at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:290)
        at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:272)
        at org.testcontainers.junit.GenericContainerRuleTest.sharedMemorySetTest(GenericContainerRuleTest.java:409)

        Caused by:
        org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
            at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
            at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:283)
            ... 2 more

            Caused by:
            org.testcontainers.containers.ContainerLaunchException: Could not create/start container
                at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:350)
                at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:285)
                at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
                ... 3 more

                Caused by:
                org.rnorth.ducttape.TimeoutException: Timeout waiting for result with exception
                    at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:54)
                    at org.rnorth.ducttape.unreliables.Unreliables.retryUntilTrue(Unreliables.java:100)
                    at org.testcontainers.containers.startupcheck.StartupCheckStrategy.waitUntilStartupSuccessful(StartupCheckStrategy.java:35)
                    at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:325)
                    ... 5 more

                    Caused by:
                    java.lang.RuntimeException: Not ready yet
@rnorth
Copy link
Member Author

rnorth commented Aug 2, 2019

This may just be a plain race condition in the test - we seem to have neither a command nor a startup strategy in place, so depending on timing we're at risk of random failure.

Will try and fix in #1680

@rnorth
Copy link
Member Author

rnorth commented Aug 10, 2019

As indicated above, I believe this was fixed in #1680, commit df65ac4 - we've not seen any further failures for this test in CI.

@rnorth rnorth closed this as completed Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant