Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead link in documentation #3129

Closed
wlad opened this issue Aug 20, 2020 · 6 comments
Closed

Dead link in documentation #3129

wlad opened this issue Aug 20, 2020 · 6 comments
Labels
good first issue help wanted

Comments

@wlad
Copy link

wlad commented Aug 20, 2020

here https://www.testcontainers.org/supported_docker_environment/

image
@wlad
Copy link
Author

wlad commented Aug 20, 2020 •
edited
Loading

this may be helpful for anybody who tries to open the broken link

https://github.com/testcontainers/testcontainers-java/blob/master/docs/supported_docker_environment/continuous_integration/circle_ci.md

Basically it says: don't use a docker executor! Instead use a machine executor.

@bsideup
Copy link
Member

bsideup commented Aug 20, 2020

Hey @wlad,

I just marked the issue as "good first issue" in case someone is looking to contribute to the project.

@wpanas
Copy link
Contributor

wpanas commented Aug 26, 2020

Hi @bsideup, I can take this one!

wpanas added a commit to wpanas/testcontainers-java that referenced this issue Aug 26, 2020
@wpanas
testcontainers#3129 Fix dead link for CircleCI configuration
2dd7917
rnorth pushed a commit that referenced this issue Aug 28, 2020
@wpanas
#3129 Fix dead link for CircleCI configuration (#3156)
c42c8ee 
Co-authored-by: wpanas <wpanas@users.noreply.github.com>
@wpanas
Copy link
Contributor

wpanas commented Sep 10, 2020

This issue can be closed

@wlad
Copy link
Author

wlad commented Sep 11, 2020

@wpanas thank you ❤️

FYI: If you use special keywords like fixes [link to issue] (i.e. fixes #3129) in your PR description when the related issue is closed automatically when your PR is accepted and merged.

check this for more details

other special keywords are:

  • close
  • closes
  • closed
  • fix
  • fixes
  • fixed
  • resolve
  • resolves
  • resolved

@wlad wlad closed this as completed Sep 11, 2020
@wpanas
Copy link
Contributor

wpanas commented Sep 11, 2020

@wlad thanks for feedback 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bsideup @wpanas @wlad