Tidy up core's build file #4207
Conversation
# Conflicts: # core/build.gradle
core/build.gradle
Outdated
| shaded 'org.zeroturnaround:zt-exec:1.12', { | ||
| exclude(group: 'org.slf4j') | ||
| } | ||
| testCompileClasspath 'org.jetbrains:annotations:21.0.1' |
There was a problem hiding this comment.
| testCompileClasspath 'org.jetbrains:annotations:21.0.1' | |
| testCompileOnly 'org.jetbrains:annotations:21.0.1' |
shouldn't be that with Only suffix? As *Classpath configurations are intended to be resolvable, but not consumable
https://discuss.gradle.org/t/what-is-a-configuration-which-cant-be-directly-resolved/30721
There was a problem hiding this comment.
It was testCompileClasspath before, so I suggest we address it separately, as this PR is something massive already :)
There was a problem hiding this comment.
okay, didn't notice it was moved
There was a problem hiding this comment.
I will try to polish this PR and reduce the changeset while fixing the merge conflict 👍
# Conflicts: # core/build.gradle
|
I just found a regression in the generated POM, will fix 👍 |
|
The issue is fixed now (and a check added that verifies that every property of POM dependencies in set (in that case, |
There was a problem hiding this comment.
I think this is looks tidier, so LGTM.
In general, it feels uncomfortable that we have to do so much scripting for all this - I wouldn't claim to understand much of what's going on here or why.
Is there some feedback we should be giving for the Shadow plugin so that they can fill any feature gaps, rather than us?
After #4171, we no longer need excludes, so I took a chance to make our build file shorter :)