Update to Gradle 7 #4171
Update to Gradle 7 #4171
Conversation
bsideup
added
area/shading
dependencies
core/build.gradle
Outdated
| for (dependency in rootNode.dependencies.children()) { | ||
| def coordinates = "${dependency.groupId.text()}:${dependency.artifactId.text()}".toString() | ||
| if (!dependencies.contains(coordinates) && !whitelist.contains(coordinates)) { | ||
| throw new IllegalStateException("New dependency! ${coordinates}") |
There was a problem hiding this comment.
Could we make this exception message more helpful for contributors?
e.g.
| throw new IllegalStateException("New dependency! ${coordinates}") | |
| throw new IllegalStateException("A new dependency has been added ${coordinates} - if this was intentional please add it to the whitelist in PATH_TO_GRADLE_FILE") |
What do we expect the process to be - do we need to be approving new dependencies somehow?
BTW I think it would be good to move this to a separate .gradle file, so that areas of major scripting are encapsulated.
There was a problem hiding this comment.
Thanks for the suggestion! We could, yes 👍
FYI this message is mostly for us, maintainers, as the chance of an external dependency added by external contributors is super low
There was a problem hiding this comment.
Extracted and made the message more user friendly 👍
| @@ -1,16 +1,16 @@ | |||
| description = "Testcontainers :: Selenium" | |||
|
|
|||
| dependencies { | |||
| compile project(':testcontainers') | |||
| api project(':testcontainers') | |||
|
|
|||
| provided 'org.seleniumhq.selenium:selenium-remote-driver:3.141.59' | |||
There was a problem hiding this comment.
BTW I've verified that the resulting POM files are effectively the same, using the approach described here, so I'm happy with this.
# Conflicts: # modules/database-commons/build.gradle # modules/dynalite/build.gradle # modules/elasticsearch/build.gradle # modules/jdbc/build.gradle # modules/junit-jupiter/build.gradle # modules/kafka/build.gradle # modules/localstack/build.gradle # modules/nginx/build.gradle # modules/vault/build.gradle
| for (dependency in rootNode.dependencies.children()) { | ||
| def coordinates = "${dependency.groupId.text()}:${dependency.artifactId.text()}".toString() | ||
| if (!dependencies.contains(coordinates) && !ignore.contains(coordinates)) { | ||
| throw new IllegalStateException("A new dependency '${coordinates}' has been added to 'org.testcontainers:${artifactId}' - if this was intentional please add it to the ignore list in ${project.buildFile}") |
No description provided.