Bug in ImageData.from(Image) causes AgeBasedPullPolicy to unexpectedly pull

[mr-rycho]

The bad fragment of ImageData.from(Image) :

return builder().createdAt(Instant.ofEpochMilli(image.getCreated())).build();

The ofEpochMilli method is used but image.getCreated() returns timestamp as epoch (seconds). This makes all images to be dated to early 1970 and AgeBasedPullPolicy always pulls images from repo, even if local images are new.
Tested with testcontainers 1.15.3
Docker:

Connected to docker: 
  Server Version: 20.10.6
  API Version: 1.41
  Operating System: Docker Desktop

[jjvrensburg]

This is still an issue in testcontainers 1.17.3.
I created the following class as a workaround:

public class CustomAgeBasedPullPolicy extends AbstractImagePullPolicy {
    Duration maxAge;

    public CustomAgeBasedPullPolicy(Duration maxAge) {
        this.maxAge = maxAge;
    }

    protected boolean shouldPullCached(DockerImageName imageName, ImageData localImageData) {
        Instant now = Instant.now();
        // Instant from image created time which is actually seconds
        Instant createdAt = Instant.ofEpochSecond(localImageData.getCreatedAt().toEpochMilli());
        Duration imageAge = Duration.between(createdAt, now);
        boolean result = imageAge.compareTo(this.maxAge) > 0;
        return result;
    }
}

[kiview]

Thanks for sharing the workaround @jjvrensburg.
Would you like to contribute a PR to fix the underlying issue?