Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Allow @Container to be used as a meta-annotation #6913

Closed
philwebb opened this issue Apr 11, 2023 · 2 comments · Fixed by #6914
Closed

[Enhancement]: Allow @Container to be used as a meta-annotation #6913

philwebb opened this issue Apr 11, 2023 · 2 comments · Fixed by #6914

Comments

@philwebb
Copy link

Module

Core

Proposal

Currently the @Container annotation in org.testcontainers.junit.jupiter has @Target(ElementType.FIELD) which prevents it being used as a meta-annotation. If ANNOTATION_TYPE were also added it could be possible to create composable annotations.

The TestcontainersExtension class uses AnnotationSupport.isAnnotated(field, Container.class) which already checks for meta-presence of annotations.

@philwebb
Copy link
Author

Thanks @eddumelendez!

@eddumelendez
Copy link
Member

@philwebb this was released as part of 1.18.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants