Support TmpFS mappings #1021
Merged
Support TmpFS mappings #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 20, 2018 15:55
…emove unused import
bsideup
reviewed
Dec 21, 2018
core/src/test/java/org/testcontainers/junit/GenericContainerRuleTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Dec 21, 2018
core/src/test/java/org/testcontainers/junit/GenericContainerRuleTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Dec 21, 2018
core/src/test/java/org/testcontainers/junit/GenericContainerRuleTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Dec 21, 2018
core/src/test/java/org/testcontainers/junit/GenericContainerRuleTest.java
Outdated
Show resolved
Hide resolved
malltshik
pushed a commit
to malltshik/testcontainers-java
that referenced
this pull request
Dec 21, 2018
malltshik
pushed a commit
to malltshik/testcontainers-java
that referenced
this pull request
Dec 21, 2018
rnorth
reviewed
Dec 23, 2018
gradle.properties
Outdated
| @@ -1,2 +1,3 @@ | |||
| org.gradle.parallel=false | |||
| org.gradle.caching=true | |||
| org.gradle.java.home=/usr/lib/jvm/java-8-openjdk-amd64/ | |||
There was a problem hiding this comment.
I think that this line should not be here - accidental commit?
There was a problem hiding this comment.
Yes indeed. My fault. I reset whole changes linked with gradle.
rnorth
approved these changes
Dec 23, 2018
bsideup
approved these changes
Dec 23, 2018
|
Thanks @malltshik! Will merge now. |
|
Thank you for your time. That was great practice for me. |
|
Released in 1.10.4! Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #673