Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"exposing host port" example #1152

Merged
merged 6 commits into from
Jan 16, 2019
Merged

"exposing host port" example #1152

merged 6 commits into from
Jan 16, 2019

Conversation

stsefanenko
Copy link
Contributor

@stsefanenko stsefanenko commented Jan 16, 2019 •
edited by bsideup
Loading

Update example, added expose host port. Fixes #1136

@bsideup bsideup changed the title Example needed: exposing host port "exposing host port" example Jan 16, 2019
@bsideup bsideup added this to the next milestone Jan 16, 2019
@bsideup
Copy link
Member

bsideup commented Jan 16, 2019

@stsefanenko great job!
I've left a few comments but it looks good in general and a great addition to our examples, well done 👍

@bsideup bsideup mentioned this pull request Jan 16, 2019
Closed
4 tasks
@bsideup bsideup merged commit 9039acb into testcontainers:master Jan 16, 2019
@bsideup
Copy link
Member

bsideup commented Jan 16, 2019

@stsefanenko merged! 🎉 Thank you for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup left review comments

@kiview kiview Awaiting requested review from kiview

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
type/docs
Projects
None yet
Milestone
1.10.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stsefanenko @bsideup