Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change megabytes for bytes in withSharedMemorySize method documentation #1215

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Change megabytes for bytes in withSharedMemorySize method documentation #1215

merged 1 commit into from
Feb 5, 2019

Conversation

aidamanna
Copy link
Contributor

This is just a simple fix for a method documentation.

In GenericContainer class, withSharedMemorySize method was accepting MB as an argument. This was changed to accept Bytes instead, but the documentation of the method was not fully changed. This PR is just doing this small doc fix.

@bsideup bsideup added this to the next milestone Feb 5, 2019
@bsideup bsideup merged commit d49f017 into testcontainers:master Feb 5, 2019
@bsideup
Copy link
Member

bsideup commented Feb 5, 2019

@aidamanna this simple fix may save hours to someone! Thank a lot for spotting and fixing it 👍

@rnorth
Copy link
Member

rnorth commented Mar 12, 2019

@rnorth rnorth removed this from the next milestone Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants