hostPort != containerPort #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Mar 22, 2019
core/src/main/java/org/testcontainers/containers/PortForwardingContainer.java
Show resolved
Hide resolved
bsideup
reviewed
Mar 22, 2019
core/src/main/java/org/testcontainers/containers/PortForwardingContainer.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Mar 22, 2019
|
@bopi- one last thing - could you please implement a test for it? |
bsideup
reviewed
Mar 25, 2019
core/src/test/java/org/testcontainers/containers/ExposedHostTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Mar 25, 2019
core/src/test/java/org/testcontainers/containers/ExposedHostTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Mar 29, 2019
core/src/test/java/org/testcontainers/containers/ExposedHostTest.java
Outdated
Show resolved
Hide resolved
|
@bopi- I just applied some minor changes myself and ready to merge as soon as the CI status is green 👍 |
yeah. naming and caching ... 😃 |
|
@bopi- merged! Thanks a lot for your contribution 👍 |
|
@bsideup thank you! Especially for your super fast responses! Do you have an Idea when this can be released? |
|
@bopi- it will be released soon since we have a couple of urgent things to be released, probably this weekend |
|
Released in 1.11.2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible that e.g. the actual hostport is a random one but in the container its always 80