Use hostname instead of hardcoded "name" string #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Mar 23, 2019
modules/toxiproxy/src/main/java/org/testcontainers/containers/ToxiproxyContainer.java
Outdated
Show resolved
Hide resolved
|
Imagine creating multiple proxies for the same host, but different port
…On Sat, 23 Mar 2019 at 15:21, worldtiki ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
modules/toxiproxy/src/main/java/org/testcontainers/containers/ToxiproxyContainer.java
<#1335 (comment)>
:
> @@ -86,7 +86,7 @@ public ContainerProxy getProxy(String hostname, int port) {
throw new IllegalStateException("Maximum number of proxies exceeded");
}
- final Proxy proxy = client.createProxy("name", "0.0.0.0:" + toxiPort, upstream);
+ final Proxy proxy = client.createProxy(hostname, "0.0.0.0:" + toxiPort, upstream);
Hi @bsideup <https://github.com/bsideup>! Thanks for the suggestion.
Happy to accept it, but I'm not quite sure why we would want to have the
port as part of the name. Is the hostname not enough?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1335 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABAIit4-a0p4E8o0iJdIwh9bvRsnGdwWks5vZjh2gaJpZM4cE7tI>
.
|
…ToxiproxyContainer.java Co-Authored-By: worldtiki <worldtiki@gmail.com>
|
@worldtiki could you please add a test for this change? |
|
Damn, this is a clear bug, sorry. The Thanks for identifying, @worldtiki. |
|
I'll contribute a test to this, in the interests of time. |
|
I've added a simple test - no need for you to add one @worldtiki. |
bsideup
approved these changes
Mar 24, 2019
|
@worldtiki thanks for spotting the bug and implementing the fix! 👍 We will release it today as a hotfix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to use hostname instead of hardcoded string to allow for multiple proxies to be created.
In my use case I have multiple proxies: one for redis, another for a mock http server, etc.
With the current implementation, when I try to create the second proxy it fails with a "409 - proxy already exists".
This is because in the "getProxy" method we have the name of the proxy hardcoded to "name".
final Proxy proxy = client.createProxy("name", "0.0.0.0:" + toxiPort, upstream);I am not sure if this requires a new test case with two proxies, and since it's the first time I'm contributing to this project I figured it would be better to get some feedback on the change before doing anything big.