924: Add docker compose support for --build and --rmi options #1336
Conversation
| public DockerComposeContainer environment = new DockerComposeContainer(new File("src/test/resources/compose-test.yml")) | ||
| .withExposedService("redis_1", REDIS_PORT) | ||
| .withExposedService("db_1", 3306) | ||
| .withBuild(true) |
There was a problem hiding this comment.
Is there anything we can do to actually verify the build and remove options work?
As it is, it seems that we’ll get a failure if the build feature throws an exception, but otherwise there’s no verification.
There was a problem hiding this comment.
I am not so into the internals of Testcontainers nur one thing which came into my mind was to verify if the image was build freshly by checking the modifcation date of the file? Would this be an option?
There was a problem hiding this comment.
We could check for the creation date of the image.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
I've just resolved some merge conflicts and pushed to your fork, @sonerd. |
|
I look into those failures tonight |
|
I need to make tweaks beyond the original merge from master, and can't write to your repository, so I have created a new branch and PR (#1625). I'll continue on that PR so that we can merge! |
Took the changes made here #924
and added test for
docker-compose --build