Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgresql 9.6.8 -> 9.6.12 #1350

Merged
merged 1 commit into from
Apr 14, 2019
Merged

Postgresql 9.6.8 -> 9.6.12 #1350

merged 1 commit into from
Apr 14, 2019

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Mar 30, 2019

No description provided.

@sullis
Copy link
Contributor Author

sullis commented Apr 2, 2019

LGTM

@rnorth
Copy link
Member

rnorth commented Apr 8, 2019

Hi @sullis
Thanks for the PR and sorry for not reviewing previously. Ordinarily we don't try to keep base images up with the latest. It's quite normal (and frankly, desirable) for people to specify whichever version of the container image they want. e.g. new PostgreSQLContainer("postgres:9.6.12").

This way tests can remain nice and stable, with Testcontainers' potentially arbitrary choice of images not being a destabilizing factor.

As a patch version update I'd not expect breaking changes, so we can accept this PR. However, I just want you to be aware that there are other options available to you.
Thanks
Richard

@rnorth rnorth merged commit 92fc7fa into testcontainers:master Apr 14, 2019
@rnorth rnorth added this to the next milestone Apr 14, 2019
@rnorth
Copy link
Member

rnorth commented Apr 16, 2019

Released in 1.11.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants