Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure pipelines #1363

Merged
merged 32 commits into from
Jul 8, 2019
Merged

Azure pipelines #1363

merged 32 commits into from
Jul 8, 2019

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Apr 7, 2019

No description provided.

@bsideup
Copy link
Member Author

bsideup commented Apr 7, 2019

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@bsideup
Copy link
Member Author

bsideup commented Apr 7, 2019

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@bsideup
Copy link
Member Author

bsideup commented Apr 9, 2019

/AzurePipelines run Windows 10 - Docker for Windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bsideup
Copy link
Member Author

bsideup commented Apr 9, 2019

/AzurePipelines run Windows 10 - Docker for Windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bsideup
Copy link
Member Author

bsideup commented Apr 9, 2019

/AzurePipelines run Windows 10 - Docker for Windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bsideup
Copy link
Member Author

bsideup commented Apr 13, 2019

/AzurePipelines run Windows 10 - Docker for Windows

@bsideup
Copy link
Member Author

bsideup commented May 28, 2019

/AzurePipelines run Windows 10 - Docker for Windows

@bsideup
Copy link
Member Author

bsideup commented Jun 2, 2019

/AzurePipelines run Windows 10 - Docker for Windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bsideup
Copy link
Member Author

bsideup commented Jun 2, 2019

/AzurePipelines run Windows 10 - Docker for Windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bsideup
Copy link
Member Author

bsideup commented Jun 2, 2019

/AzurePipelines run Windows 10 - Docker for Windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bsideup
Copy link
Member Author

bsideup commented Jun 2, 2019

/AzurePipelines run Windows 10 - Docker for Windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bsideup
Copy link
Member Author

bsideup commented Jun 3, 2019

/AzurePipelines run Windows 10 - Docker for Windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kiview
kiview approved these changes Jun 17, 2019
View reviewed changes
azure-pipelines.yml
inputs:
gradleWrapperFile: 'gradlew'
jdkVersionOption: '1.8'
options: '--no-daemon --continue'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we actually use the daemon?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't, given that it is running on an actual machine that being reused and may cause troubles

modules/jdbc-test/src/test/java/org/testcontainers/jdbc/JDBCDriverTest.java
boolean result = new QueryRunner(dataSource, options.contains(Options.PmdKnownBroken)).query("SELECT 1", rs -> {
rs.next();
int resultSetInt = rs.getInt(1);
assertEquals("A basic SELECT query succeeds", 1, resultSetInt);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably missing something (and it's just copied from the original code), but why don't we return resultSetInt == 1 instead of the assertEquals?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just an indentation change. Let's discuss/change it separately :)

@rnorth rnorth removed this from the next milestone Jul 7, 2019
@bsideup
Copy link
Member Author

bsideup commented Jul 7, 2019

/AzurePipelines run Windows 10 - Docker for Windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bsideup
Copy link
Member Author

bsideup commented Jul 7, 2019

/AzurePipelines run Windows 10 - Docker for Windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bsideup
Copy link
Member Author

bsideup commented Jul 8, 2019

/AzurePipelines run Windows 10 - Docker for Windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bsideup
Copy link
Member Author

bsideup commented Jul 8, 2019

/AzurePipelines run Windows 10 - Docker for Windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kiview
kiview approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bsideup bsideup added this to the next milestone Jul 8, 2019
@bsideup bsideup merged commit ed01433 into master Jul 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the azure_pipelines branch July 8, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@kiview kiview kiview approved these changes

Assignees
No one assigned
Labels
os/linux os/windows type/housekeeping type/test-improvement
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bsideup @rnorth @kiview