Add build args and Dockerfile path override to ImageFromDockerfile #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Apr 8, 2019
core/src/test/java/org/testcontainers/images/builder/DockerfileBuildTest.java
Show resolved
Hide resolved
bsideup
reviewed
Apr 8, 2019
bsideup
approved these changes
Apr 8, 2019
|
Released in 1.11.2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using ImageFromDockerfile for testing base images at Skyscanner. The ability to specify a Dockerfile path and build args have both come up as areas where we can make the developer experience a bit better.
As part of this change I've improved the docs quite a bit, including clarifying everyone's bugbear around providing every file to the build context explicitly. Note that #1348 is a slight wrinkle in the approach documented here, but I think it is OK to fix that separately (the issue serves as documentation of that limitation until we solve it).