Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch exception when trying to kill dead container #1420

Merged
merged 1 commit into from
Jul 16, 2019
Merged

catch exception when trying to kill dead container #1420

merged 1 commit into from
Jul 16, 2019

Conversation

chungngoops
Copy link
Contributor

Refs: #1379

@bsideup bsideup added this to the next milestone Jul 16, 2019
@bsideup bsideup merged commit 371b325 into testcontainers:master Jul 16, 2019
rnorth added a commit that referenced this pull request Jul 24, 2019
@rnorth
Amend container shutdown to catch and log for all Exception classes
04932a3 
Replacement for #1420 to fix incomplete error handling
Refs #1379
@rnorth rnorth mentioned this pull request Jul 24, 2019
Merged
rnorth added a commit that referenced this pull request Aug 10, 2019
@rnorth
Amend container shutdown to catch and log for all Exception cla… (#1663)
4d1ba9e 
* Amend container shutdown to catch and log for all Exception classes
Replacement for #1420 to fix incomplete error handling
Refs #1379

* Log root cause exception message rather than immediate exception's message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chungngoops @bsideup