Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in docs (describe use of stop() method rather than close()) #1479

Merged
merged 1 commit into from
May 28, 2019
Merged

Fix typo in docs (describe use of stop() method rather than close()) #1479

merged 1 commit into from
May 28, 2019

Conversation

izeye
Copy link
Contributor

@izeye izeye commented May 20, 2019

This seems to be a typo.

rnorth
rnorth approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @izeye - it's borderline whether this is a bug in the docs, as close() calls stop(). However, your edit helps make the docs clearer and easier to grok, so LGTM. Thank you!

@rnorth rnorth changed the title Fix typo Fix typo in docs (describe use of stop() method rather than close()) May 28, 2019
@rnorth rnorth merged commit 4325c2a into testcontainers:master May 28, 2019
@izeye izeye deleted the patch-1 branch May 28, 2019 09:07
@rnorth rnorth added this to the next milestone May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
type/docs
Projects
None yet
Milestone
1.11.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@izeye @rnorth