Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spock quickstart documentation #1499

Merged
merged 5 commits into from
Jun 3, 2019

Conversation

RSchlenker
Copy link
Contributor

References: #1162

Thanks @antrew & @kiview
Created at hackergarten @ gr8conf 2019.

@kiview
Copy link
Member

kiview commented May 27, 2019

Of course there is quite some content overlap with the JUnit4 quickstart documentation.
We decided to do this, to give Spock users the complete information necessary without looking at the JUnit4 quickstart.

Is it possible to include text snippets from other markdown files?

@rnorth
Copy link
Member

rnorth commented May 27, 2019

This looks great, thanks! I think it's also conceptually close to @bmuschko's #1416 - it's good to move in the same direction.

Re:

Is it possible to include text snippets from other markdown files?

Could you clarify further? Are you thinking about reducing duplication between the *_quickstart.md files?

@kiview
Copy link
Member

kiview commented May 29, 2019

Could you clarify further? Are you thinking about reducing duplication between the *_quickstart.md files?

Exactly this. So the introductory text is the same, but it makes sense to have everything right there on this single page, it will give a new user the best quickstart experience.

docs/quickstart/spock_quickstart.md Outdated Show resolved Hide resolved
Co-Authored-By: Kevin Wittek <kiview@users.noreply.github.com>
@rnorth
Copy link
Member

rnorth commented May 29, 2019

I don't think we can do straight includes in markdown at present, but that's maybe a future improvement we can make.

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @RSchlenker!

@kiview kiview added this to the next milestone Jun 3, 2019
@kiview kiview merged commit 369cfe1 into testcontainers:master Jun 3, 2019
@kiview
Copy link
Member

kiview commented Jun 3, 2019

Merged, thanks a lot @RSchlenker and @antrew!

qibinlou added a commit to qibinlou/testcontainers-java that referenced this pull request Jun 3, 2019
Signed-off-by: Leo Lou <llou@squarespace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants