Upgrade localstack and enable new services #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Some services need a newer Localstack version
Also extend basic tests to cover SQS
This was referenced May 28, 2019
rnorth
commented
May 28, 2019
| @@ -5,4 +5,5 @@ dependencies { | |||
|
|
|||
| compileOnly 'com.amazonaws:aws-java-sdk-s3:1.11.479' | |||
| testCompile 'com.amazonaws:aws-java-sdk-s3:1.11.479' | |||
| testCompile 'com.amazonaws:aws-java-sdk-sqs:1.11.479' | |||
rnorth
commented
May 28, 2019
| @@ -82,20 +82,11 @@ public LocalStackContainer withServices(Service... services) { | |||
| final String address = getContainerIpAddress(); | |||
| String ipAddress = address; | |||
| try { | |||
| // resolve IP address and use that as the endpoint so that path-style access is automatically used for S3 | |||
There was a problem hiding this comment.
See javadocs - using an IP address for the endpoint ensures that the AWS SDK uses path-style access under the covers, which is the desired effect for the newer version of Localstack.
We use InetAddress.getByName(...) to convert the container IP address to an IP regardless of its original form (e.g. could be localhost, could already be an IP, could be a hostname).
The endpoint URL returned by this helper method is strictly for use by the Docker host.
rnorth
commented
May 28, 2019
| STEPFUNCTIONS("stepsfunctions", 4585), | ||
| CLOUDWATCHLOGS("cloudwatchlogs", 4586), | ||
| STS("sts", 4592), | ||
| IAM("iam", 4593); |
There was a problem hiding this comment.
Reformatted; @trollinger74940 added new services here.
This was referenced May 28, 2019
ImFlog
reviewed
Jun 5, 2019
...s/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1413
Fixes #1496