Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault: add a fluent API for configuring Vault's logging level #2231

Merged

Conversation

fullkomnun
Copy link

Setting the logging level of Vault is useful while debugging Vault Container.
Added a fluent-API to allow easier/safer setting of logging level.

@stale
Copy link

stale bot commented Apr 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Apr 5, 2020
@stale stale bot removed the stale label Apr 5, 2020
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking a long time to review. I think this is fine. A test would be nice to have, but ultimately the implementation is so simple that I think the difficulty of testing would outweigh.

@rnorth rnorth changed the title add a fluent API for configuring Vault's logging level Vault: add a fluent API for configuring Vault's logging level Oct 14, 2020
@rnorth rnorth added this to the next milestone Oct 14, 2020
@rnorth rnorth merged commit e64db24 into testcontainers:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants